Telemetry Updates#149
Merged
Merged
Conversation
… Added code to send Exceptions/errors
vishiy
reviewed
Oct 23, 2018
| pluginConfig, err := ReadConfiguration(pluginConfPath) | ||
| if err != nil { | ||
| Log("Error Reading plugin config path : %s \n", err.Error()) | ||
| SendException(err) |
Member
There was a problem hiding this comment.
You might want to send the string that you are logging below this line as well. Else you dont know from where all these errors are coming from and hard to match to code. Applicable to all SendException calls..
vishiy
reviewed
Oct 23, 2018
| if len(splitStrings) > 0 && len(splitStrings) < 10 { | ||
| CommonProperties["SubscriptionID"] = splitStrings[2] | ||
| CommonProperties["ResourceGroupName"] = splitStrings[4] | ||
| CommonProperties["ClusterName"] = splitStrings[8] |
Member
There was a problem hiding this comment.
Check for bounds rather than assuming [8] exists
vishiy
reviewed
Oct 23, 2018
vishiy
reviewed
Oct 24, 2018
vishiy
approved these changes
Oct 25, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.